On Mon 29 Oct 2007 18:22, Andrew Morton pondered: > I hit numerous rejects here. I am not sure which kernel you patched but > I suspect it was not an up-to-date one.
Sorry about that - I will do so in the future. Thanks for reviewing and fixing up. > > --- kernel/kallsyms.c (revision 3780) > > +++ kernel/kallsyms.c (working copy) > > Please prepare patches in `patch -p1' form. This should have been > > --- foo/kernel/kallsyms.c (revision 3780) > +++ bar/kernel/kallsyms.c (working copy) Sorry twice. > > */ > > if ((s->addr == _etext && strcmp((char*)s->sym + offset, > > "_etext")) || > > - (s->addr == _einittext && strcmp((char*)s->sym + offset, > > "_einittext")) || > > - (s->addr == _eextratext && strcmp((char*)s->sym + offset, > > "_eextratext"))) > > + (s->addr == _einittext && strcmp((char*)s->sym + offset, > > "_einittext"))) > > return 0; > > } > > I don't understand why this hunk is changing _einittext handling, and I > suspect this was a mistake, so I left that bit out. I didn't think I did change the _einittext handling - just removed _eextratext, and removed the trailing ||, and closed the parentheses for the if statement. - (s->addr == _einittext && strcmp((char*)s->sym + offset, "_einittext")) || + (s->addr == _einittext && strcmp((char*)s->sym + offset, "_einittext"))) I think this is the same as what you have here - isn't it? > - if ((s->addr == _etext && strcmp((char*)s->sym + offset, > "_etext")) || > - (s->addr == _einittext && strcmp((char*)s->sym + offset, > "_einittext")) || > - (s->addr == _eextratext && strcmp((char*)s->sym + offset, > "_eextratext"))) > + if ((s->addr == _etext && > + strcmp((char*)s->sym + offset, "_etext")) || > + (s->addr == _einittext && > + strcmp((char*)s->sym + offset, "_einittext"))) > return 0; ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
