On Wed, Jul 22, 2020 at 02:07:56PM +0200, Drew Fustini wrote: > Change the handling of pin config flags from if/else to switch > statement to make the code more readable and cleaner. > > Suggested-by: Gustavo A. R. Silva <[email protected]> > Signed-off-by: Drew Fustini <[email protected]>
Acked-by: Gustavo A. R. Silva <[email protected]> Thanks, Drew. -- Gustavo > --- > drivers/gpio/gpio-omap.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index e0eada82178c..7fbe0c9e1fc1 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -899,13 +899,18 @@ static int omap_gpio_set_config(struct gpio_chip *chip, > unsigned offset, > u32 debounce; > int ret = -ENOTSUPP; > > - if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE) || > - (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP) || > - (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_DOWN)) { > + switch (pinconf_to_config_param(config)) { > + case PIN_CONFIG_BIAS_DISABLE: > + case PIN_CONFIG_BIAS_PULL_UP: > + case PIN_CONFIG_BIAS_PULL_DOWN: > ret = gpiochip_generic_config(chip, offset, config); > - } else if (pinconf_to_config_param(config) == > PIN_CONFIG_INPUT_DEBOUNCE) { > + break; > + case PIN_CONFIG_INPUT_DEBOUNCE: > debounce = pinconf_to_config_argument(config); > ret = omap_gpio_debounce(chip, offset, debounce); > + break; > + default: > + break; > } > > return ret; > -- > 2.25.1 >
