On Tue, Oct 30 2007, Herbert Xu wrote: > On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > > On Fri, Oct 26 2007, Herbert Xu wrote: > > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > > > This patch moves the sg_init_table out of the timing loops for hash > > > algorithms so that it doesn't impact on the speed test results. > > > > Wouldn't it be better to just make sg_init_one() call sg_init_table? > > This looks fine to me although I think it's orthogonal to the > patch you were quoting :)
How so? The reason you changed it to sg_init_table() + sg_set_buf() is exactly because sg_init_one() didn't properly init the entry (as they name promised). -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
