Re: [PATCH 1/2] Bluetooth: hci_h5: Set HCI_UART_RESET_ON_INIT to correct flags

[Hans de Goede]

Hi,

On 7/21/20 4:37 AM, Nicolas Boichat wrote:

HCI_UART_RESET_ON_INIT belongs in hdev_flags, not flags.

Fixes: ce945552fde4a09 ("Bluetooth: hci_h5: Add support for serdev enumerated 
devices")
Signed-off-by: Nicolas Boichat <drink...@chromium.org>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdego...@redhat.com>

Regards,

Hans

---

  drivers/bluetooth/hci_h5.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index e60b2e0773db110..e41854e0d79aae2 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -793,7 +793,7 @@ static int h5_serdev_probe(struct serdev_device *serdev)
        if (!h5)
                return -ENOMEM;

- set_bit(HCI_UART_RESET_ON_INIT, &h5->serdev_hu.flags);

+       set_bit(HCI_UART_RESET_ON_INIT, &h5->serdev_hu.hdev_flags);

h5->hu = &h5->serdev_hu;

        h5->serdev_hu.serdev = serdev;