From: Vadym Kochan <vadym.koc...@plvision.eu>
Date: Fri, 24 Jul 2020 17:19:52 +0300

> +int prestera_dsa_parse(struct prestera_dsa *dsa, const u8 *dsa_buf)
> +{
> +     u32 *dsa_words = (u32 *)dsa_buf;
 ...
> +     words[0] = ntohl((__force __be32)dsa_words[0]);
> +     words[1] = ntohl((__force __be32)dsa_words[1]);
> +     words[2] = ntohl((__force __be32)dsa_words[2]);
> +     words[3] = ntohl((__force __be32)dsa_words[3]);

Isn't is much easier to declare dsa_words as a "__be32 *" instead of
cast after cast after cast?

> +int prestera_dsa_build(const struct prestera_dsa *dsa, u8 *dsa_buf)
> +{
> +     __be32 *dsa_words = (__be32 *)dsa_buf;

Which you did properly here.

Reply via email to