On Sat, 25 Jul 2020 11:23:39 +0200
Pavel Machek <pa...@ucw.cz> wrote:

> Hi!
> 
> > +static const struct marvell_led_mode_info marvell_led_mode_info[] = {
> > +   { "link",                       { 0x0,  -1, 0x0,  -1,  -1,  -1, }, 0 },
> > +   { "link/act",                   { 0x1, 0x1, 0x1, 0x1, 0x1, 0x1, }, 0 },
> > +   { "1Gbps/100Mbps/10Mbps",       { 0x2,  -1,  -1,  -1,  -1,  -1, }, 0 }, 
> >  
> 
> is this "1Gbps-10Mbps"?

Most of these modes mean "ON on event", eg
  "link" means ON when link up, else OFF. "
  "tx" means ON on when transmitting, else OFF
  "act" means ON when activity, else OFF
  "copper" means ON when copper link up, else OFF
but some are blinking modes
  "blink-act" means BLINK when activity, else OFF

Some modes can do ON and BLINK, these have one '/' in their name
  "link/act" means ON when link up, BLINK on activity, else OFF
  "link/rx" means ON when link up, BLINK on receive, else OFF

there is one mode, "1Gbps/100Mbps/10Mbps", which behaves differently:
  blinks 3 times when linked on 1Gbps
  blinks 2 times when linked on 100Mbps
  blinks 1 time when linked on 10Mbps
(and this blinking is repeating, ie blinks 3 times, pause, blinks 3 times,
pause)

Some modes are disjunctive:
  "100Mbps-fiber" means ON when linked on 100Mbps or via fiber, else OFF


> 
> > +   { "act",                        { 0x3, 0x3, 0x3, 0x3, 0x3, 0x3, }, 0 },
> > +   { "blink-act",                  { 0x4, 0x4, 0x4, 0x4, 0x4, 0x4, }, 0 },
> > +   { "tx",                         { 0x5,  -1, 0x5,  -1, 0x5, 0x5, }, 0 },
> > +   { "tx",                         {  -1,  -1,  -1, 0x5,  -1,  -1, }, 
> > L3V5_TRANS },
> > +   { "rx",                         {  -1,  -1,  -1,  -1, 0x0, 0x0, }, 0 },
> > +   { "rx",                         {  -1, 0x0,  -1,  -1,  -1,  -1, }, 
> > L1V0_RECV },
> > +   { "copper",                     { 0x6,  -1,  -1,  -1,  -1,  -1, }, 0 },
> > +   { "copper",                     {  -1, 0x0,  -1,  -1,  -1,  -1, }, 
> > L1V0_COPPER },
> > +   { "1Gbps",                      { 0x7,  -1,  -1,  -1,  -1,  -1, }, 0 },
> > +   { "link/rx",                    {  -1, 0x2,  -1, 0x2, 0x2, 0x2, }, 0 },
> > +   { "100Mbps-fiber",              {  -1, 0x5,  -1,  -1,  -1,  -1, }, 
> > L1V5_100_FIBER },
> > +   { "100Mbps-10Mbps",             {  -1, 0x5,  -1,  -1,  -1,  -1, }, 
> > L1V5_100_10 },
> > +   { "1Gbps-100Mbps",              {  -1, 0x6,  -1,  -1,  -1,  -1, }, 0 },
> > +   { "1Gbps-10Mbps",               {  -1,  -1, 0x6, 0x6,  -1,  -1, }, 0 },
> > +   { "100Mbps",                    {  -1, 0x7,  -1,  -1,  -1,  -1, }, 0 },
> > +   { "10Mbps",                     {  -1,  -1, 0x7,  -1,  -1,  -1, }, 0 },
> > +   { "fiber",                      {  -1,  -1,  -1, 0x0,  -1,  -1, }, 
> > L3V0_FIBER },
> > +   { "fiber",                      {  -1,  -1,  -1, 0x7,  -1,  -1, }, 
> > L3V7_FIBER },
> > +   { "FullDuplex",                 {  -1,  -1,  -1, 0x7,  -1,  -1, }, 
> > L3V7_DUPLEX },
> > +   { "FullDuplex",                 {  -1,  -1,  -1,  -1, 0x6, 0x6, }, 0 },
> > +   { "FullDuplex/collision",       {  -1,  -1,  -1,  -1, 0x7, 0x7, }, 0 },
> > +   { "FullDuplex/collision",       {  -1,  -1, 0x2,  -1,  -1,  -1, }, 
> > L2V2_DUPLEX },
> > +   { "ptp",                        {  -1,  -1, 0x2,  -1,  -1,  -1, }, 
> > L2V2_PTP },
> > +   { "init",                       {  -1,  -1, 0x2,  -1,  -1,  -1, }, 
> > L2V2_INIT },
> > +   { "los",                        {  -1,  -1,  -1, 0x0,  -1,  -1, }, 
> > L3V0_LOS },
> > +   { "hi-z",                       { 0xa, 0xa, 0xa, 0xa, 0xa, 0xa, }, 0 },
> > +   { "blink",                      { 0xb, 0xb, 0xb, 0xb, 0xb, 0xb, }, 0 },
> > +};  
> 
> Certainly more documentation will be required here, what "ptp" setting
> does, for example, is not very obvious to me.

"ptp" means it will light up when the PTP functionality is enabled on
the PHY and a PTP packet is received.

> Best regards,
>                                                                       Pavel

Reply via email to