Zach Brown wrote:
Timur Tabi wrote:
I'm running checkpatch.pl (dated 10/17), and it complains about this line:
crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
Well, that is a bit of a stinker. Maybe it could be reworked a little
to make it easier for humans and checkpatch to understand?
__be32 *crazy_pointer = (void *)firmware + calc_size;
crc = be32_to_cpu(*crazy_pointer);
I admit the code might be convoluted, but it's perfectly valid, and it
eliminates the need for "crazy_pointer". I'm much more inclined to ignore
the checkpatch error than to redesign my code.
Besides, your argument is a bit of a strawman. The real problem is with
checkpatch.
(Does this need to worry about get_unaligned() at all?)
Well, I suppose it's technically possible, but only if my data has been
corrupted.
--
Timur Tabi
Linux kernel developer at Freescale
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
