On Mon, 27 Jul 2020, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 03:04:07AM +0000, Xu Wang wrote: > > Simplify the return expression. > > I understand your intention, but I would rather leave as is. > It's a bit more helpful in the original form in case to add some debugging.
If you wish to add debugging, you'll have to add the extra line of code yourself. :) > It also keep it symmetrical with read() counterpart. Can this be fixed-up too? > That said, I'm not objecting the change if Lee finds it good enough. > > > Signed-off-by: Xu Wang <vu...@iscas.ac.cn> > > --- > > drivers/mfd/intel_soc_pmic_mrfld.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog