Hi Azhar,
On Tue, Jul 28, 2020 at 02:24:46PM -0700, Azhar Shaikh wrote: > usb_role_switch_set_role() has the second argument as enum for usb_role. > Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. > This eventually translates to USB_ROLE_NONE in case of UFP and > USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum > values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of > UFP. nit: DFP > > Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control") > Signed-off-by: Azhar Shaikh <azhar.sha...@intel.com> > Cc: Prashant Malani <pmal...@chromium.org> Reviewed-by: Prashant Malani <pmal...@chromium.org> > --- > drivers/platform/chrome/cros_ec_typec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c > b/drivers/platform/chrome/cros_ec_typec.c > index 3eae01f4c9f7..eb4713b7ae14 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -590,7 +590,8 @@ static int cros_typec_port_update(struct cros_typec_data > *typec, int port_num) > dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret); > > return usb_role_switch_set_role(typec->ports[port_num]->role_sw, > - !!(resp.role & PD_CTRL_RESP_ROLE_DATA)); > + resp.role & PD_CTRL_RESP_ROLE_DATA > + ? USB_ROLE_HOST : USB_ROLE_DEVICE); > } > > static int cros_typec_get_cmd_version(struct cros_typec_data *typec) > -- > 2.17.1 >