On Wed, Jul 29, 2020 at 12:18:42PM +0300, Denis Efremov wrote: > > > On 7/28/20 5:19 PM, Peilin Ye wrote: > > raw_cmd_copyout() is potentially copying uninitialized kernel stack memory > > since it is initializing `cmd` by assignment, which may cause the compiler > > to leave uninitialized holes in this structure. Fix it by using memcpy() > > instead. > > > > Cc: [email protected] > > Fixes: 2145e15e0557 ("floppy: don't write kernel-only members to FDRAWCMD > > ioctl output") > > Nitpick, I would say this fix is not related to commit 2145e15e0557.
I see, I will send a v2 soon. Thank you for reviewing the patch! Peilin Ye > > Suggested-by: Dan Carpenter <[email protected]> > > Suggested-by: Arnd Bergmann <[email protected]> > > Signed-off-by: Peilin Ye <[email protected]>
