Hi Peng, On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote: > Support sharing vdev buffer between multiple vdevs by using name > "vdevbuffer". > > Reviewed-by: Richard Zhu <hongxing....@nxp.com> > Signed-off-by: Peng Fan <peng....@nxp.com> > --- > drivers/remoteproc/remoteproc_virtio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c > b/drivers/remoteproc/remoteproc_virtio.c > index dfd3808c34fd..5d78ebea111e 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > > /* Try to find dedicated vdev buffer carveout */ > mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer", rvdev->index); > + if (!mem) > + mem = rproc_find_carveout_by_name(rproc, "vdevbuffer");
We already have a way to share buffers [1], do you think it would work for you? I would rather proceed that way to avoid introducing a 3rd way to deal with vdev buffers. Thanks, Mathieu [1]. https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/remoteproc/remoteproc_virtio.c#L389 > if (mem) { > phys_addr_t pa; > > -- > 2.16.4 >
