On Thu, Jul 30, 2020 at 05:07:05PM +0300, Kirill Tkhai wrote: > On 30.07.2020 16:35, Christian Brauner wrote: > > On Thu, Jul 30, 2020 at 02:59:25PM +0300, Kirill Tkhai wrote: > >> Currently, every type of namespaces has its own counter, > >> which is stored in ns-specific part. Say, @net has > >> struct net::count, @pid has struct pid_namespace::kref, etc. > >> > >> This patchset introduces unified counter for all types > >> of namespaces, and converts net namespace to use it first. > >> > >> Signed-off-by: Kirill Tkhai <ktk...@virtuozzo.com> > >> --- > > > > Any reason the refcount changes need to be tied to the procfs changes? > > Seems that should be a separate cleanup patchset which we can take > > independent of procfs changes. > > Yes, patches [1-8] are cleanup, it may go separately. > > For me there is no a problem to resend them also as a separate patchset, > say at v2, or if there is a change in 1-8, but I'm afraid to bomb mailboxes. > > If there is no a request for rework in 1-8, can they be picked directly from > here?
Apart from the missing include that might be an issue in ns_common.h this looks fine to me and seems like a good cleanup overall. Afaict it even loses more code than it adds. I think resending this part separately is worth it given that we're not sure whether this series will be part of procfs or a spearate thing. This won't make it for the merge window of course but unless there are technical issues with this conversion I'd pick this up for later. Thanks! Christian
