Hi Prashant,
> -----Original Message----- > From: Prashant Malani <pmal...@chromium.org> > Sent: Thursday, July 30, 2020 4:03 PM > To: Shaikh, Azhar <azhar.sha...@intel.com> > Cc: ble...@chromium.org; enric.balle...@collabora.com; > gro...@chromium.org; linux-kernel@vger.kernel.org; > heikki.kroge...@linux.intel.com; Patel, Utkarsh H > <utkarsh.h.pa...@intel.com>; Bowman, Casey G > <casey.g.bow...@intel.com>; Mani, Rajmohan > <rajmohan.m...@intel.com> > Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting > usb role during disconnect > > Hi Azhar, > > On Thu, Jul 30, 2020 at 03:56:09PM -0700, Azhar Shaikh wrote: > > On disconnect port partner is removed and usb role is set to NONE. > > But then in cros_typec_port_update() the role is set again. > > Avoid this by moving usb_role_switch_set_role() to > > cros_typec_configure_mux(). > > > > Signed-off-by: Azhar Shaikh <azhar.sha...@intel.com> > > Suggested-by: Prashant Malani <pmal...@chromium.org> > > --- > > drivers/platform/chrome/cros_ec_typec.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/platform/chrome/cros_ec_typec.c > > b/drivers/platform/chrome/cros_ec_typec.c > > index eb4713b7ae14..df97431b2275 100644 > > --- a/drivers/platform/chrome/cros_ec_typec.c > > +++ b/drivers/platform/chrome/cros_ec_typec.c > > @@ -515,6 +515,12 @@ static int cros_typec_configure_mux(struct > cros_typec_data *typec, int port_num, > > if (ret) > > return ret; > > > > + ret = usb_role_switch_set_role(typec->ports[port_num]->role_sw, > > + pd_ctrl->role & > PD_CTRL_RESP_ROLE_DATA > > + ? USB_ROLE_HOST : USB_ROLE_DEVICE); > > + if (ret) > > + return ret; > > Since this was the last switch being configured, please maintain the same > order and add this at the end of the function, after the if-else if block. > Please correct if my understanding is not correct here: Set the orientation , set the role, then configure the mux. Shouldn't this be the order? > Best regards, > > -Prashant
