On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
>> + if (mod->using_gplonly_symbols) {
>> + pr_info("%s: module using GPL-only symbols uses symbols from
>> proprietary module %s.\n",
>> + mod->name, owner->name);
>
> pr_err() maybe?
>
>> + return false;
>> + }
>> +
>> + if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
>> + pr_info("%s: module uses symbols from proprietary module %s,
>> inheriting taint.\n",
>> + mod->name, owner->name);
>
> and pr_warn()? But otherwise this looks much better.
Ok with me. Can you just fix it up, or do you want a full resend?
