Srikar Dronamraju <sri...@linux.vnet.ibm.com> writes: > * Michael Ellerman <m...@ellerman.id.au> [2020-07-31 18:02:21]: > >> Srikar Dronamraju <sri...@linux.vnet.ibm.com> writes: >> > Lookup the coregroup id from the associativity array. > > Thanks Michael for all your comments and inputs. > >> It's slightly strange that this is called in patch 9, but only properly >> implemented here in patch 10. >> >> I'm not saying you have to squash them together, but it would be good if >> the change log for patch 9 mentioned that a subsequent commit will >> complete the implementation and how that affects the behaviour. > > I probably got influenced by few LKML community members who always add a > stub and implement the gory details in a subsequent patch. I will surely add > the change log in patch 9 about the subsequent patches.
That's OK, it's a valid way to do things, and can be good for keeping the size of individual patches down to make them easier to review. But yeah a mention in the change log of the preceeding patch is helpful for anyone looking at that commit on its own in the future. cheers