On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: 8777e4314d397 ("scsi: qla2xxx: Migrate NVME N2N handling into state 
machine")
Cc: Quinn Tran <quinn.t...@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zh...@linux.alibaba.com>
---
 drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index fa695a4007f8..a8da6be52b18 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -678,7 +678,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha)
        struct nvme_fc_port_template *tmpl;
        struct qla_hw_data *ha;
        struct nvme_fc_port_info pinfo;
-       int ret = EINVAL;
+       int ret = -EINVAL;
 
        if (!IS_ENABLED(CONFIG_NVME_FC))
                return ret;
-- 
2.26.2

Reply via email to