On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: 7a5c938b9ed09 ("IB/core: Check for rdma_protocol_ib only after 
validating port_num")
Cc: Jason Gunthorpe <j...@ziepe.ca>
Signed-off-by: Tianjia Zhang <tianjia.zh...@linux.alibaba.com>
---
 drivers/infiniband/core/verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 53d6505c0c7b..f369f0a19e85 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1712,7 +1712,7 @@ static int _ib_modify_qp(struct ib_qp *qp, struct 
ib_qp_attr *attr,
                if (!(rdma_protocol_ib(qp->device,
                                       attr->alt_ah_attr.port_num) &&
                      rdma_protocol_ib(qp->device, port))) {
-                       ret = EINVAL;
+                       ret = -EINVAL;
                        goto out;
                }
        }
-- 
2.26.2

Reply via email to