This patch performs the following changes:
1. remove a redundant parentheses around the  nvkm_acr_lsfw_add() calls
2. do assignment before this if condition, it is more readable

Signed-off-by: Jing Xiangfeng <jingxiangf...@huawei.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index 07d1830126ab..5f6006418472 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -191,7 +191,8 @@ nvkm_acr_lsfw_load_bl_inst_data_sig(struct nvkm_subdev 
*subdev,
        u32 *bldata;
        int ret;
 
-       if (IS_ERR((lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id))))
+       lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id);
+       if (IS_ERR(lsfw))
                return PTR_ERR(lsfw);
 
        ret = nvkm_firmware_load_name(subdev, path, "bl", ver, &bl);
-- 
2.17.1

Reply via email to