[PATCH 5.7 029/120] drm: of: Fix double-free bug

[Greg Kroah-Hartman]

From: Biju Das <biju.das...@bp.renesas.com>

commit 4ee48cc5586bf519df19894273002aa8ef7b70ad upstream.

Fix double-free bug in the error path.

Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: Pavel Machek <pa...@denx.de>
Signed-off-by: Biju Das <biju.das...@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: sta...@vger.kernel.org
Signed-off-by: Sam Ravnborg <s...@ravnborg.org>
Link: 
https://patchwork.freedesktop.org/patch/msgid/1595502654-40595-1-git-send-email-biju.das...@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/gpu/drm/drm_of.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -322,10 +322,8 @@ static int drm_of_lvds_get_remote_pixels
                 * configurations by passing the endpoints explicitly to
                 * drm_of_lvds_get_dual_link_pixel_order().
                 */
-               if (!current_pt || pixels_type != current_pt) {
-                       of_node_put(remote_port);
+               if (!current_pt || pixels_type != current_pt)
                        return -EINVAL;
-               }
        }
 
        return pixels_type;