On Sat, 27 Oct 2007 16:19:46 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:

> --- a/drivers/video/sis/sis_main.c
> +++ b/drivers/video/sis/sis_main.c
> @@ -1245,24 +1245,25 @@ sisfb_do_set_var(struct fb_var_screeninfo *var, int 
> isactive, struct fb_info *in
>               ivideo->sisfb_mode_idx++;
>       }
>  
>       if(found_mode) {
>               ivideo->sisfb_mode_idx = sisfb_validate_mode(ivideo,
>                               ivideo->sisfb_mode_idx, ivideo->currentvbflags);
> -             ivideo->mode_no = 
> sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];
>       } else {
>               ivideo->sisfb_mode_idx = -1;
>       }
>  
>               if(ivideo->sisfb_mode_idx < 0) {
>               printk(KERN_ERR "sisfb: Mode %dx%dx%d not supported\n", 
> var->xres,
>                      var->yres, var->bits_per_pixel);
>               ivideo->sisfb_mode_idx = old_mode;
>               return -EINVAL;
>       }
>  
> +     ivideo->mode_no = 
> sisbios_mode[ivideo->sisfb_mode_idx].mode_no[ivideo->mni];

oic, sisfb_validate_mode() could have returned a -ve error code.

Please use the changelog to fully explain your patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to