On Tue, Aug 04, 2020 at 04:56:34PM +0200, Cornelia Huck wrote: > On Mon, 3 Aug 2020 17:00:01 -0400 > "Michael S. Tsirkin" <[email protected]> wrote: > > > mlxbf-tmfifo accesses config space using native types - > > which works for it since the legacy virtio native types. > > > > This will break if it ever needs to support modern virtio, > > so with new tags previously introduced for virtio net config, > > sparse now warns for this in drivers. > > > > Since this is a legacy only device, fix it up using > > virtio_legacy_is_little_endian for now. > > I'm wondering if the driver should make this more explicit?
Not sure how though. > No issues with the patch, though. > > > > > No functional changes. > > > > Signed-off-by: Michael S. Tsirkin <[email protected]> > > --- > > drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > Acked-by: Cornelia Huck <[email protected]>
