On Wed, Aug 05, 2020 at 09:31:28AM +0100, Christoph Hellwig wrote: > On Tue, Aug 04, 2020 at 01:28:01PM +0200, Christian Brauner wrote: > > High-level this does two main things: > > 1. Remove the double export of both do_fork() and _do_fork() where do_fork() > > used the incosistent legacy clone calling convention. Now we only export > > _do_fork() which is based on struct kernel_clone_args. > > Can we retire the _do_fork name as well please? For one we really don't > use single underscore prefix in the kernel, and we also try to avoid our > normal __ prefixes if there is no non-prefixed vesion. Also the name > feels wrong, as this implements all of clone and not just fork. > What about kernel_clone to match the name of the args structure?
Yep, sounds good. I actually had a patch for that but it introduced a lot of jitter into the series because there's quite a few odd places where _do_fork() is used. > > Also none of them actaully is exported (thankfully!). Ah, sorry that was confusing. What I meant was "exported" in the sense of visible outside of the file not actually in the "useable from modules" sense. Thanks! Christian
