On Tue, Aug 04, 2020 at 11:20:21AM +0200, Pavel Machek wrote: > On Tue 2020-08-04 11:18:17, Pavel Machek wrote: > > Hi! > > > > > The commit text again to make checkpatch happy. > > > > ? > > > > > > > + oneOf: > > > + - items: > > > + - const: ctu,ctucanfd > > > + - const: ctu,canfd-2 > > > + - const: ctu,ctucanfd > > > > For consistency, can we have ctu,canfd-1, ctu,canfd-2? > > Make it ctu,ctucanfd-1, ctu,ctucanfd-2... to make it consistent with > the file names.
If you are going to do version numbers, please define where they come from. Hopefully some tag of the h/w IP version... Better yet, put version numbers in the h/w registers itself and you don't need different compatibles. Rob
