On Fri, Aug 07, 2020 at 11:00:11AM +0800, 何鑫 wrote: > Xin He <[email protected]> 于2020年7月21日周二 下午6:17写道： > > > > From: Qi Liu <[email protected]> > > > > We should put the reference count of the fence after calling > > virtio_gpu_cmd_submit(). So add the missing dma_fence_put(). > > > > Fixes: 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit > > synchronization") > > Co-developed-by: Xin He <[email protected]> > > Signed-off-by: Xin He <[email protected]> > > Signed-off-by: Qi Liu <[email protected]> > > Reviewed-by: Muchun Song <[email protected]> > > --- > > > > changelog in v3: > > 1) Change the subject from "drm/virtio: fixed memory leak in > > virtio_gpu_execbuffer_ioctl()" to > > "drm/virtio: fix missing dma_fence_put() in > > virtio_gpu_execbuffer_ioctl()" > > 2) Rework the commit log > > > > changelog in v2: > > 1) Add a change description > > > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > index 5df722072ba0..19c5bc01eb79 100644 > > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > @@ -179,6 +179,7 @@ static int virtio_gpu_execbuffer_ioctl(struct > > drm_device *dev, void *data, > > > > virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, > > vfpriv->ctx_id, buflist, out_fence); > > + dma_fence_put(&out_fence->f); > > virtio_gpu_notify(vgdev); > > return 0; > > > > -- > > 2.21.1 (Apple Git-122.3) > > > > cc Greg
Why? $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/virtio/virtgpu_ioctl.c David Airlie <[email protected]> (maintainer:VIRTIO GPU DRIVER) Gerd Hoffmann <[email protected]> (maintainer:VIRTIO GPU DRIVER) Daniel Vetter <[email protected]> (maintainer:DRM DRIVERS) Sumit Semwal <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK) "Christian König" <[email protected]> (maintainer:DMA BUFFER SHARING FRAMEWORK) [email protected] (open list:VIRTIO GPU DRIVER) [email protected] (open list:VIRTIO GPU DRIVER) [email protected] (open list) [email protected] (open list:DMA BUFFER SHARING FRAMEWORK) [email protected] (moderated list:DMA BUFFER SHARING FRAMEWORK)
