Hi YourName, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master] [also build test WARNING on v5.8 next-20200807] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/YourName/drivers-bluetooth-btintel-c-fixed-format-issue/20200809-152614 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master config: i386-randconfig-m021-20200809 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> smatch warnings: drivers/bluetooth/btintel.c:32 btintel_check_bdaddr() warn: inconsistent indenting vim +32 drivers/bluetooth/btintel.c 48f0ed1bb68589 Marcel Holtmann 2015-04-06 22 48f0ed1bb68589 Marcel Holtmann 2015-04-06 23 int btintel_check_bdaddr(struct hci_dev *hdev) 48f0ed1bb68589 Marcel Holtmann 2015-04-06 24 { 48f0ed1bb68589 Marcel Holtmann 2015-04-06 25 struct hci_rp_read_bd_addr *bda; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 26 struct sk_buff *skb; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 27 48f0ed1bb68589 Marcel Holtmann 2015-04-06 28 skb = __hci_cmd_sync(hdev, HCI_OP_READ_BD_ADDR, 0, NULL, 48f0ed1bb68589 Marcel Holtmann 2015-04-06 29 HCI_INIT_TIMEOUT); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 30 if (IS_ERR(skb)) { 48f0ed1bb68589 Marcel Holtmann 2015-04-06 31 int err = PTR_ERR(skb); 2064ee332e4c1b Marcel Holtmann 2017-10-30 @32 bt_dev_err(hdev, "Reading Intel device address failed (%d)", 2064ee332e4c1b Marcel Holtmann 2017-10-30 33 err); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 34 return err; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 35 } 48f0ed1bb68589 Marcel Holtmann 2015-04-06 36 48f0ed1bb68589 Marcel Holtmann 2015-04-06 37 if (skb->len != sizeof(*bda)) { 2064ee332e4c1b Marcel Holtmann 2017-10-30 38 bt_dev_err(hdev, "Intel device address length mismatch"); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 39 kfree_skb(skb); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 40 return -EIO; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 41 } 48f0ed1bb68589 Marcel Holtmann 2015-04-06 42 48f0ed1bb68589 Marcel Holtmann 2015-04-06 43 bda = (struct hci_rp_read_bd_addr *)skb->data; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 44 48f0ed1bb68589 Marcel Holtmann 2015-04-06 45 /* For some Intel based controllers, the default Bluetooth device 48f0ed1bb68589 Marcel Holtmann 2015-04-06 46 * address 00:03:19:9E:8B:00 can be found. These controllers are 48f0ed1bb68589 Marcel Holtmann 2015-04-06 47 * fully operational, but have the danger of duplicate addresses 48f0ed1bb68589 Marcel Holtmann 2015-04-06 48 * and that in turn can cause problems with Bluetooth operation. 48f0ed1bb68589 Marcel Holtmann 2015-04-06 49 */ 48f0ed1bb68589 Marcel Holtmann 2015-04-06 50 if (!bacmp(&bda->bdaddr, BDADDR_INTEL)) { 2064ee332e4c1b Marcel Holtmann 2017-10-30 51 bt_dev_err(hdev, "Found Intel default device address (%pMR)", 2064ee332e4c1b Marcel Holtmann 2017-10-30 52 &bda->bdaddr); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 53 set_bit(HCI_QUIRK_INVALID_BDADDR, &hdev->quirks); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 54 } 48f0ed1bb68589 Marcel Holtmann 2015-04-06 55 48f0ed1bb68589 Marcel Holtmann 2015-04-06 56 kfree_skb(skb); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 57 48f0ed1bb68589 Marcel Holtmann 2015-04-06 58 return 0; 48f0ed1bb68589 Marcel Holtmann 2015-04-06 59 } 48f0ed1bb68589 Marcel Holtmann 2015-04-06 60 EXPORT_SYMBOL_GPL(btintel_check_bdaddr); 48f0ed1bb68589 Marcel Holtmann 2015-04-06 61 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
