On Fri, 2 Nov 2007 14:24:24 +0800, Bryan Wu wrote:
> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]>
> ---
> drivers/i2c/busses/i2c-bfin-twi.c | 19 ++++++++++++-------
> 1 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-bfin-twi.c
> b/drivers/i2c/busses/i2c-bfin-twi.c
> index 727625b..ae41c0b 100644
> --- a/drivers/i2c/busses/i2c-bfin-twi.c
> +++ b/drivers/i2c/busses/i2c-bfin-twi.c
> @@ -37,6 +37,15 @@
> #include <asm/portmux.h>
> #include <asm/irq.h>
>
> +#define DRV_NAME "i2c-bfin-twi"
> +#define DRV_AUTHOR "Sonic Zhang, Bryan Wu"
What's the point this define when you're using it only once, a few
lines below?
> +#define DRV_DESC "Blackfin BF5xx on-chip I2C TWI Contoller Driver"
> +#define DRV_VERSION "1.8"
> +
> +MODULE_AUTHOR(DRV_AUTHOR);
> +MODULE_DESCRIPTION(DRV_DESC);
> +MODULE_LICENSE("GPL");
> +
> #define POLL_TIMEOUT (2 * HZ)
>
> /* SMBus mode*/
> @@ -701,8 +710,8 @@ static int i2c_bfin_twi_probe(struct platform_device
> *pdev)
> else
> platform_set_drvdata(pdev, iface);
>
> - dev_info(&pdev->dev, "Blackfin I2C TWI controller, [EMAIL PROTECTED]",
> - iface->regs_base);
> + dev_info(&pdev->dev, "%s, Version %s, [EMAIL PROTECTED]",
> + DRV_DESC, DRV_VERSION, iface->regs_base);
You're mixing device and driver here. DRV_DESC describes the driver,
while this dev_info() refers to a specific device. So I don't see more
confusion than benefit with this change. If you want to expose the
driver version, you'd rather user MODULE_VERSION().
>
> return rc;
>
> @@ -735,7 +744,7 @@ static struct platform_driver i2c_bfin_twi_driver = {
> .suspend = i2c_bfin_twi_suspend,
> .resume = i2c_bfin_twi_resume,
> .driver = {
> - .name = "i2c-bfin-twi",
> + .name = DRV_NAME,
> .owner = THIS_MODULE,
> },
> };
> @@ -750,9 +759,5 @@ static void __exit i2c_bfin_twi_exit(void)
> platform_driver_unregister(&i2c_bfin_twi_driver);
> }
>
> -MODULE_AUTHOR("Sonic Zhang <[EMAIL PROTECTED]>");
> -MODULE_DESCRIPTION("I2C-Bus adapter routines for Blackfin TWI");
> -MODULE_LICENSE("GPL");
> -
> module_init(i2c_bfin_twi_init);
> module_exit(i2c_bfin_twi_exit);
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
