Hi, > -----Original Message----- > From: Heikki Krogerus <[email protected]> > Sent: Tuesday, August 11, 2020 6:07 AM > To: Prashant Malani <[email protected]>; Shaikh, Azhar > <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Patel, Utkarsh H > <[email protected]>; Bowman, Casey G > <[email protected]>; Mani, Rajmohan > <[email protected]> > Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Avoid setting > usb role during disconnect > > Hi, > > On Thu, Aug 06, 2020 at 11:39:08AM -0700, Prashant Malani wrote: > > I would suggest: > > - Merging Patch 1 (role set correction) and Patch 2 (moving the > > usb_role_switch_set_role() inside cros_typec_configure_mux() > > *but* keep it at the end to preserve existing ordering) into 1 patch. > > - Add another patch which re-orders the calls and which in the commit > > message lists out all the reasons why this re-ordering needs to be > > done. > > > > Doing the above will help keep better track of why the changes were > made. > > So Azhar can you please prepare v3? >
Sure, sent v3. > > thanks, > > -- > Heikki Regards, Azhar
