On 2020-08-14 10:12, Dmitry Baryshkov wrote:
Hello,
On 12/08/2020 07:42, Tanmay Shah wrote:
From: Chandan Uddaraju <chand...@codeaurora.org>
[skipped]
+ } else if ((dp_parser_check_prefix("ctrl", clk_name) ||
+ dp_parser_check_prefix("stream", clk_name)) &&
+ ctrl_clk_index < ctrl_clk_count) {
+ struct dss_clk *clk =
+ &ctrl_power->clk_config[ctrl_clk_index];
+ strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name));
+ ctrl_clk_index++;
+
+ if (!strncmp(clk_name, "ctrl_link",
+ strlen("ctrl_link")) ||
+ !strncmp(clk_name, "stream_pixel",
+ strlen("ctrl_pixel")))
This should be "stream_pixel", I believe. I don't like macros, but
most probably it would help here. Also function/brace alignment could
be better (sorry, it really hides the issue here).
Thanks for reviews and good catch!! I completely missed it when I
renamed "ctrl_pixel".
Use of "stream_pixel" is very limited. So, instead of macros direct name
is used.
Fixing function and brace alignment sounds good idea insted.
+ clk->type = DSS_CLK_PCLK;
+ else
+ clk->type = DSS_CLK_AHB;
+ }
+ }
