Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag.  Code is smaller and
simpler.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/extcon/extcon-ptn5150.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 12e52ddbd77e..3b99ad41b06e 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
 
        info->dev = &i2c->dev;
        info->i2c = i2c;
-       info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
+       info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW);
        if (IS_ERR(info->vbus_gpiod)) {
                dev_err(dev, "failed to get VBUS GPIO\n");
                return PTR_ERR(info->vbus_gpiod);
        }
-       ret = gpiod_direction_output(info->vbus_gpiod, 0);
-       if (ret) {
-               dev_err(dev, "failed to set VBUS GPIO direction\n");
-               return -EINVAL;
-       }
 
        mutex_init(&info->mutex);
 
-- 
2.17.1

Reply via email to