On Mon, 5 Nov 2007, Greg KH wrote:
> >
> > This one is bogus:
> >
> > PCI: Revert "PCI: disable MSI by default on systems with Serverworks
> > HT1000 chips"
> >
> > This reverts commit e3008dedff4bdc96a5f67224cd3d8d12237082a0.
> >
> > The real bug was an INTX issue in the tg3 ethernet chip, and
> > cured by commit c129d962a66c76964954a98b38586ada82cf9381
> >
> > Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
> > Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
> > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
>
> I'll defer to David on this one, as he sent it to me.
Btw, I'd also like to take the opportunitity to ask people to always
include the explanation of the commit when you give a commit ID.
"git revert" does that for the commit it reverts, but the (bogus) commit
ID that was apparently added by David (c129d962a) didn't get the
explanation for it, so now it's totally impossible to match it up with
anything at all..
So let me one more say:
- don't just say
.. was cured by commit xyz
- but add the one-liner description of the commit, something along the
lines of
.. was cured by commit xyz ("PCI: Add quirk for devices which
disable MSI when INTX_DISABLE is set.")
so that the commit messages are readable even outside git.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
