On Wed, Aug 12, 2020 at 02:12:57PM -0500, David Lechner wrote: > On 8/12/20 2:02 PM, Alex Dewar wrote: > > On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote: > > > On 8/12/20 8:37 AM, Alex Dewar wrote: > > > > On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: > > > > > On 8/9/20 1:54 PM, Alex Dewar wrote: > > > > > > This battery appears only to be used by a single board (DA850), so > > > > > > it > > > > > > makes sense to add this to the Kconfig file so that users don't > > > > > > build > > > > > > the module unnecessarily. It currently seems to be built for the x86 > > > > > > Arch Linux kernel where it's probably not doing much good. > > > > > > > > > > It would probably also make sense to add "default n" since it only > > > > > applies to one board in the entire arch. > > > > > > > > Ah ok. That makes sense. Would you like me to send a follow-on patch for > > > > this? > > > > > > You can just send a v2 patch that includes the change below and the > > > additional change. > > > > I've just had a look at the documentation[1] and it seems that as there's > > no "default y" there it'll default to n anyway. Have I got that right? > > > > [1] > > https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes > > > > Yes, that seems right. That makes me wonder why this would have been enabled > in > the Arch Linux kernel for x86 then.
Not sure, maybe the Arch devs like Lego? ;-) Are you happy to give an Acked-by for this anyhoo? @Sebastian, are you happy to pick up this patch? Best, Alex
