Em Tue, 18 Aug 2020 11:13:51 +0200 Mauro Carvalho Chehab <[email protected]> escreveu:
> Em Mon, 17 Aug 2020 14:12:11 -0600 > Rob Herring <[email protected]> escreveu: > > > > + 'irq-mask-addr': > > > + description: Address for the interrupt request mask > > > + > > > + 'irq-addr': > > > + description: Address for the interrupt request > > Those two seems more standard to me: irq-mask-addr is the address to > enable/disable IRQs, while irq-addr is where the pending IRQs are > stored. > > What would be the standard way to specify them both? After another look at the driver, both seems to be fixed address. There are even some comments that implies that: /* SOC_PMIC_IRQ_MASK_0_ADDR */ ret = of_property_read_u32(np, "irq-mask-addr", &pmic->irq_mask_addr); /* SOC_PMIC_IRQ0_ADDR */ ret = of_property_read_u32(np, "irq-addr", &pmic->irq_addr); So, I'll just drop the entire set of irq-* properties. The PMIC part should be just this: #include <dt-bindings/spmi/spmi.h> ... pmic: pmic@0 { compatible = "hisilicon,hi6421v600-spmi"; reg = <0 SPMI_USID>; #interrupt-cells = <2>; interrupt-controller; gpios = <&gpio28 0 0>; ... }; Thanks, Mauro
