Hi Enric,
> -----Original Message-----
> From: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Sent: Tuesday, August 18, 2020 6:38 AM
> To: Shaikh, Azhar <azhar.sha...@intel.com>; ble...@chromium.org;
> gro...@chromium.org; heikki.kroge...@linux.intel.com;
> pmal...@chromium.org
> Cc: linux-kernel@vger.kernel.org; Mani, Rajmohan
> <rajmohan.m...@intel.com>; Patel, Utkarsh H <utkarsh.h.pa...@intel.com>;
> Bowman, Casey G <casey.g.bow...@intel.com>
> Subject: Re: [PATCH v3 1/3] platform/chrome: cros_ec_typec: Send enum
> values to usb_role_switch_set_role()
>
> Hi Azhar,
>
> Thank you for your patch.
>
> On 11/8/20 21:37, Azhar Shaikh wrote:
> > usb_role_switch_set_role() has the second argument as enum for
> usb_role.
> > Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
> > This eventually translates to USB_ROLE_NONE in case of UFP and
> > USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum
> > values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of
> > DFP.
> >
> > Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux
> > control")
> >
>
> No extra line here.
Ack
>
> > Signed-off-by: Azhar Shaikh <azhar.sha...@intel.com>
>
> Did the Prashant reviewed tag disappear for some reason? Can you resend
> the patches with all the collected tags? (looks like this patch and others
> from
> this series already have been reviewed)
>
Sorry about that, will add the tags back.
> Thanks,
> Enric
>
> > ---
> > Changes in v3:
> > - No changes
> >
> > Changes in v2:
> > - Update the commit message to change 'USB_ROLE_HOST in case of
> > UFP.' to 'USB_ROLE_HOST in case of DFP.'
> >
> > drivers/platform/chrome/cros_ec_typec.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c
> > b/drivers/platform/chrome/cros_ec_typec.c
> > index 3fcd27ec9ad8..06108212ee94 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -591,7 +591,8 @@ static int cros_typec_port_update(struct
> cros_typec_data *typec, int port_num)
> > dev_warn(typec->dev, "Configure muxes failed, err = %d\n",
> ret);
> >
> > return usb_role_switch_set_role(typec->ports[port_num]-
> >role_sw,
> > - !!(resp.role &
> PD_CTRL_RESP_ROLE_DATA));
> > + resp.role & PD_CTRL_RESP_ROLE_DATA
> > + ? USB_ROLE_HOST : USB_ROLE_DEVICE);
> > }
> >
> > static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
> >
