On Tue, Nov 06, 2007 at 09:04:02PM +0530, Kamalesh Babulal wrote: > Hi Andrew, > > The build fails with following error > > CC drivers/pci/hotplug/rpadlpar_sysfs.o > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not > constant > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for > `dlpar_io_kset.kobj.parent') > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: initializer element is not > constant > drivers/pci/hotplug/rpadlpar_sysfs.c:133: error: (near initialization for > `dlpar_io_kset.kobj') > drivers/pci/hotplug/rpadlpar_sysfs.c:134: error: unknown field `ktype' > specified in initializer > drivers/pci/hotplug/rpadlpar_sysfs.c:134: warning: initialization from > incompatible pointer type > make[3]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1 > make[2]: *** [drivers/pci/hotplug] Error 2 > make[1]: *** [drivers/pci] Error 2 > make: *** [drivers] Error 2 > > The patch, > gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch > is causing the build failure.
Actually, in looking at that file some more, the whole way that file creates sysfs files and uses them is so messed up it's not funny (get the return value of writing to a file by reading from it? WTF?) I'll go clean up all this crap now that we can do simple kobject attributes easier... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/