On Mon, Aug 17, 2020 at 05:04:12PM -0500, Eric W. Biederman wrote: > Use the helper fget_task and simplify the code. > > As well as simplifying the code this removes one unnecessary increment of > struct files_struct. This unnecessary increment of files_struct.count can > result in exec unnecessarily unsharing files_struct and breaking posix > locks, and it can result in fget_light having to fallback to fget reducing > performance. > > Suggested-by: Oleg Nesterov <o...@redhat.com> > Signed-off-by: "Eric W. Biederman" <ebied...@xmission.com> Reviewed-by: Cyrill Gorcunov <gorcu...@gmail.com>
I really like this simplification!