On Sat, 22 Aug 2020 at 13:46, Krzysztof Kozlowski <k...@kernel.org> wrote: > > On Sat, Aug 22, 2020 at 01:21:47PM -0700, Florian Fainelli wrote: > > > > > > On 8/22/2020 1:14 PM, Markus Mayer wrote: > > > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski <k...@kernel.org> wrote: > > > > > > > > On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: > > > > > On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski <k...@kernel.org> > > > > > wrote: > > > > > > > > > > > > On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: > > > > > > > We would overrun the error_text array if we hit a TIMEOUT > > > > > > > condition, > > > > > > > because we were using the error code "ETIMEDOUT" (which is 110) > > > > > > > as an > > > > > > > array index. > > > > > > > > > > > > > > We fix the problem by correcting the array index and by providing > > > > > > > a > > > > > > > function to retrieve error messages rather than accessing the > > > > > > > array > > > > > > > directly. The function includes a bounds check that prevents the > > > > > > > array > > > > > > > from being overrun. > > > > > > > > > > > > > > This patch was prepared in response to > > > > > > > https://lkml.org/lkml/2020/8/18/505. > > > > > > > > > > > > > > Signed-off-by: Markus Mayer <mma...@broadcom.com> > > > > > > > > > > > > Your Signed-off-by does not match From field. Please run > > > > > > scripts/checkpatch on every patch you send. > > > > > > > > > > > > I fixed it up, assuming markus.ma...@broadcom.com is the valid email > > > > > > address. > > > > > > > > > > No. I have always been using mma...@broadcom.com since it is shorter. > > > > > That's also what's in the MAINTAINERS file. Please change it back. I > > > > > accidentally used the long form for one of my e-mail replies which is > > > > > where the confusion must have originated. > > > > > > > > I'll drop the patch then. You need to resend with SoB matching email. > > > > > > Oh, I am starting to see what's happening here. This is new and > > > apparently due to some changes with the mail server setup on our end. > > > > > > I have this in my patch file: > > > > > > $ head 0001-memory-brcmstb_dpfe-fix-array-index-out-of-bounds.patch > > > From 6b424772d4c84fa56474b2522d0d3ed6b2b2b360 Mon Sep 17 00:00:00 2001 > > > From: Markus Mayer <mma...@broadcom.com> > > > Date: Fri, 21 Aug 2020 08:56:52 -0700 > > Which means your patch actually passed checkpatch on your computer so my > comment about running it was not smart... :)
It did pass, yes. :-) > > > Sending patches like this used to work. Clearly our SMTP server has > > > now taken it upon itself to rewrite the sender e-mail address. I > > > wasn't expecting that. Let me look into it. Sorry for the hassle. It > > > was not intentional. > > > > Yes, if you used to use the SMTP relay server which did not require > > authentication for internal hosts, and now you use smtp.gmail.com with your > > broadcom.com username, the SMTP server will rewrite the From: to match the > > username used to authenticate with the server. > > Markus' patch did not go via GMail. It was the Broadcom server which > mangled the things. The email headers: Indeed. > Received: by mail.kernel.org (Postfix) > Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com > [192.19.229.170]) > by mail.kernel.org (Postfix) with ESMTPS id D5B3B20702 > Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net > [10.75.242.48]) > Received: from lbrmn-mmayer.ric.broadcom.net (lbrmn-mmayer.ric.broadcom.net > [10.136.28.150]) > From: Markus Mayer <markus.ma...@broadcom.com> > > Neither kernel.org nor my final server (Gmail) cares about usernames in > From fields of some specific domain. > > I guess you could try configure you git send email to use email of > "markus.mayer" while keeping Author "mmayer". You have to configure git > send email for this and such configuration results in proper two "From" > fields which maybe smtp broadcom won't change. Yep. I think I've got it set up now. Stay tuned. > Best regards, > Krzysztof
