On Nov 7, 2007 11:50 PM, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > +#define PAGETABLE_LEVELS 3 > + > +typedef u64 pteval_t; > +typedef u64 pmdval_t; > +typedef u64 pudval_t; > +typedef u64 pgdval_t; > +
> -static inline unsigned long long native_pgd_val(pgd_t pgd) > +static inline pgdval_t native_pgd_val(pgd_t pgd) > { Maybe these kind of things, the typedef and native_xxx definitions can go into the common header, after we define the PAGETABLE_LEVELS constant? I think the more goes into common headers, the better. > -static inline pte_t native_make_pte(unsigned long long val) > +static inline pte_t native_make_pte(pteval_t val) > { > return (pte_t) { .pte_low = val, .pte_high = (val >> 32) } ; > } Although these make_xxx things can probably be just left here... -- Glauber de Oliveira Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/