On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > The dp_com resource is always at index 1 according to the dts files in > the kernel. Get this resource by index so that we don't need to make > future additions to the DT binding use 'reg-names'. >
Afaict the DT binding for the USB/DP phy defines that there should be a reg name of "dp_com" and the current dts files all specifies this. Am I missing something? PS. Why isn't this a devm_platform_ioremap_resource{,_byname}()? Regards, Bjorn > Cc: Jeykumar Sankaran <jsa...@codeaurora.org> > Cc: Chandan Uddaraju <chand...@codeaurora.org> > Cc: Vara Reddy <va...@codeaurora.org> > Cc: Tanmay Shah <tan...@codeaurora.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Manu Gautam <mgau...@codeaurora.org> > Cc: Sandeep Maheswaram <s...@codeaurora.org> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Sean Paul <seanp...@chromium.org> > Cc: Jonathan Marek <jonat...@marek.ca> > Cc: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > Cc: Rob Clark <robdcl...@chromium.org> > Signed-off-by: Stephen Boyd <swb...@chromium.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c > b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 40c051813c34..76d7a9e80f04 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -3266,8 +3266,7 @@ static int qcom_qmp_phy_probe(struct platform_device > *pdev) > > /* per PHY dp_com; if PHY has dp_com control block */ > if (cfg->has_phy_dp_com_ctrl) { > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "dp_com"); > + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > base = devm_ioremap_resource(dev, res); > if (IS_ERR(base)) > return PTR_ERR(base); > -- > Sent by a computer, using git, on the internet >