On Wed, 26 Aug 2020 at 22:48, Krzysztof Kozlowski <k...@kernel.org> wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
Acked-by: Chunyan Zhang <zhang.l...@gmail.com> Thanks! > --- > drivers/pwm/pwm-sprd.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c > index be2394227423..5123d948efd6 100644 > --- a/drivers/pwm/pwm-sprd.c > +++ b/drivers/pwm/pwm-sprd.c > @@ -228,11 +228,8 @@ static int sprd_pwm_clk_init(struct sprd_pwm_chip *spc) > if (ret == -ENOENT) > break; > > - if (ret != -EPROBE_DEFER) > - dev_err(spc->dev, > - "failed to get channel clocks\n"); > - > - return ret; > + return dev_err_probe(spc->dev, ret, > + "failed to get channel > clocks\n"); > } > > clk_pwm = chn->clks[SPRD_PWM_CHN_OUTPUT_CLK].clk; > -- > 2.17.1 >