On 2020-08-27, Al Viro <[email protected]> wrote: > On Wed, Aug 26, 2020 at 02:48:19PM -0600, Ross Zwisler wrote: > > > Al, now that the changes to fs/namei.c have landed and we're past the merge > > window for v5.9, what are your thoughts on this patch and the associated > > test? > > Humm... should that be nd->path.mnt->mnt_flags or link->mnt->mnt_flags? > Usually it's the same thing, but they might differ. IOW, is that about the > directory we'd found it in, or is it about the link itself?
Now that you mention it, I think link->mnt->mnt_flags makes more sense. The restriction should apply in the context of whatever filesystem contains the symlink, and that would matches FreeBSD's semantics (at least as far as I can tell from a quick look at sys/kern/vfs_lookup.c). -- Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH <https://www.cyphar.com/>
signature.asc
Description: PGP signature
