> The vast majority of which are either memory-mapped hardware registers or > interrupt-routine-filled ring buffers.
memory mapped registers should be read with readw and friends and that should contain the volatile not the public code. Similarly spin_lock/unlock are store barriers so for ring buffers should be sufficient unless you have cache management requirements in which case the dma_* APIs will handle those bits. Knocking these sort of things on the head does want doing, we are still having to clean up ancient drivers/platforms that don't do this and frequently break as a result. > | WARNING: do not add new typedefs > | #27265: FILE: include/asm-mn10300/types.h:30: > | +typedef unsigned int __u32; > > Pah! Send bugs to the maintainer. You've triggered a new case - adding an arch and it gets the wrong idea. > > | #29191: FILE: include/asm-mn10300/user.h:50: > | +#define HOST_TEXT_START_ADDR +(u.start_code) > | ^ > | > | ERROR: need consistent spacing around '+' (ctx:WxV) > > Doesn't checkpatch know a unary plus when it sees one? No - its rather dumb on rule handling and will need a rewrite someday to handle typedefs as well. > #1269: FILE: arch/mn10300/boot/compressed/head.S:38: > > Should be: > > arch/mn10300/boot/compressed/head.S:38: > > Yes, I know there's a --emacs flag, but that only affects references into the > patch, not references into the files the patch refers to. Send patches... Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/