Hi! Wrong subject. Made me overlook it on the first pass...
On 2020-08-27 21:26, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > --- > drivers/iio/multiplexer/iio-mux.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/multiplexer/iio-mux.c > b/drivers/iio/multiplexer/iio-mux.c > index 6910218fdb00..d219d4a86657 100644 > --- a/drivers/iio/multiplexer/iio-mux.c > +++ b/drivers/iio/multiplexer/iio-mux.c > @@ -354,11 +354,8 @@ static int mux_probe(struct platform_device *pdev) > return -ENODEV; > > parent = devm_iio_channel_get(dev, "parent"); > - if (IS_ERR(parent)) { > - if (PTR_ERR(parent) != -EPROBE_DEFER) > - dev_err(dev, "failed to get parent channel\n"); > - return PTR_ERR(parent); > - } > + if (IS_ERR(parent)) > + return dev_err_probe(dev, PTR_ERR(parent), "failed to get > parent channel\n"); As per the comment for 9/18, I'm not a fan of the long line here... Cheers, Peter > > sizeof_ext_info = iio_get_channel_ext_info_count(parent); > if (sizeof_ext_info) { >
