Hi :) On Fri, Aug 28, 2020 at 10:18:44AM +0200, [email protected] wrote: > On Fri, Aug 28, 2020 at 03:07:06AM +0200, Ahmed S. Darwish wrote: > > At seqlock.h, sequence counters with associated locks are either called > > seqcount_LOCKNAME_t, seqcount_LOCKTYPE_t, or seqcount_locktype_t. > > > > Standardize on "seqcount_LOCKTYPE_t" for all instances in comments, > > kernel-doc, and SEQCOUNT_LOCKTYPE() generative macro paramters. > > > +#define SEQCOUNT_LOCKTYPE(locktype, locktype_t, preemptible, lockmember) > > \ > > +typedef struct seqcount_##locktype { > > \ > > + __SEQ_LOCK(locktype_t *lock); \ > > +} seqcount_##locktype##_t; \ > > Hurmph, so my thinking was that the above 'locktype' is not actually a > type and therefore a misnomer. > > But I see your point about it being a bit of a mess. > > Would: > > s/LOCKTYPE/LOCKNAME/g > s/seqcount_locktype_t/seqcount_LOCKNAME_t/g > > help? Then we're consistently at: seqcount_LOCKNAME_t, which is a type. >
Sounds good, will do. Thanks, -- Ahmed S. Darwish Linutronix GmbH
