>> Nack, we shoiuld never include userspace headers in kernel headers, >> an even more never add !__KERNEL__ ifdefs. Just make sure your >> programs include limit.h before including linux/cdrom.h. > >I think header files should be complete, and should not use undefined >macros, picking up every random definition that may be in effect when >the header is included, don't you agree?
No, because I be damn sure that some developers try compiling programs in non-linux environments (cygwin, solaris, andyourpersonaldistro, you name it) which do not have to adhere to <limits.h>. It might use <cosmiclimits.h> instead, or whatever. Hence, such extra includes are a nogo. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/