Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/rtc/rtc-s3c.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index e1b50e682fc4..24a41909f049 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -494,13 +494,8 @@ static int s3c_rtc_probe(struct platform_device *pdev)
        if (info->data->needs_src_clk) {
                info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src");
                if (IS_ERR(info->rtc_src_clk)) {
-                       ret = PTR_ERR(info->rtc_src_clk);
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(&pdev->dev,
-                                       "failed to find rtc source clock\n");
-                       else
-                               dev_dbg(&pdev->dev,
-                                       "probe deferred due to missing rtc src 
clk\n");
+                       ret = dev_err_probe(&pdev->dev, 
PTR_ERR(info->rtc_src_clk),
+                                           "failed to find rtc source 
clock\n");
                        goto err_src_clk;
                }
                ret = clk_prepare_enable(info->rtc_src_clk);
-- 
2.17.1

Reply via email to