Using full paths to extend or override a device tree node is error prone
since if there was a typo error, a new node will be created instead of
extending the node as it was desired.  This will lead to run-time errors
that could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 arch/arm/boot/dts/exynos4412-midas.dtsi | 34 +++++++++++--------------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi 
b/arch/arm/boot/dts/exynos4412-midas.dtsi
index 32d2e539b2dd..7e7c243ff196 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -319,25 +319,6 @@
                pulldown-ohm = <100000>; /* 100K */
                io-channels = <&adc 2>;  /* Battery temperature */
        };
-
-       thermal-zones {
-               cpu_thermal: cpu-thermal {
-                       cooling-maps {
-                               map0 {
-                                    /* Corresponds to 800MHz at freq_table */
-                                    cooling-device = <&cpu0 7 7>, <&cpu1 7 7>,
-                                                     <&cpu2 7 7>, <&cpu3 7 7>;
-                               };
-                               map1 {
-                                    /* Corresponds to 200MHz at freq_table */
-                                    cooling-device = <&cpu0 13 13>,
-                                                     <&cpu1 13 13>,
-                                                     <&cpu2 13 13>,
-                                                     <&cpu3 13 13>;
-                              };
-                      };
-               };
-       };
 };
 
 &adc {
@@ -406,6 +387,21 @@
        cpu0-supply = <&buck2_reg>;
 };
 
+&cpu_thermal {
+       cooling-maps {
+               map0 {
+                       /* Corresponds to 800MHz at freq_table */
+                       cooling-device = <&cpu0 7 7>, <&cpu1 7 7>,
+                                        <&cpu2 7 7>, <&cpu3 7 7>;
+               };
+               map1 {
+                       /* Corresponds to 200MHz at freq_table */
+                       cooling-device = <&cpu0 13 13>, <&cpu1 13 13>,
+                                        <&cpu2 13 13>, <&cpu3 13 13>;
+               };
+       };
+};
+
 &csis_0 {
        status = "okay";
        vddcore-supply = <&ldo8_reg>;
-- 
2.17.1

Reply via email to