Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/i2c/busses/i2c-cadence.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index e4b7f2a951ad..eefde554c50c 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -1214,11 +1214,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
                 "Cadence I2C at %08lx", (unsigned long)r_mem->start);
 
        id->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(id->clk)) {
-               if (PTR_ERR(id->clk) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "input clock not found.\n");
-               return PTR_ERR(id->clk);
-       }
+       if (IS_ERR(id->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),
+                                    "input clock not found.\n");
+
        ret = clk_prepare_enable(id->clk);
        if (ret)
                dev_err(&pdev->dev, "Unable to enable clock.\n");
-- 
2.17.1

Reply via email to