Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
---
 drivers/clk/clk-gpio.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 38755a241ab7..a3cc53edcb11 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -199,7 +199,6 @@ static int gpio_clk_driver_probe(struct platform_device 
*pdev)
        struct gpio_desc *gpiod;
        struct clk_hw *hw;
        bool is_mux;
-       int ret;
 
        is_mux = of_device_is_compatible(node, "gpio-mux-clock");
 
@@ -211,17 +210,10 @@ static int gpio_clk_driver_probe(struct platform_device 
*pdev)
 
        gpio_name = is_mux ? "select" : "enable";
        gpiod = devm_gpiod_get(dev, gpio_name, GPIOD_OUT_LOW);
-       if (IS_ERR(gpiod)) {
-               ret = PTR_ERR(gpiod);
-               if (ret == -EPROBE_DEFER)
-                       pr_debug("%pOFn: %s: GPIOs not yet available, retry 
later\n",
-                                       node, __func__);
-               else
-                       pr_err("%pOFn: %s: Can't get '%s' named GPIO 
property\n",
-                                       node, __func__,
-                                       gpio_name);
-               return ret;
-       }
+       if (IS_ERR(gpiod))
+               return dev_err_probe(dev, PTR_ERR(gpiod),
+                                    "%pOFn: Can't get '%s' named GPIO 
property\n",
+                                    node, gpio_name);
 
        if (is_mux)
                hw = clk_hw_register_gpio_mux(dev, gpiod);
-- 
2.17.1

Reply via email to