If something fails after calling v4l2_device_register(),
it should call v4l2_device_put().

Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
---
 drivers/media/test-drivers/vivid/vivid-core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/test-drivers/vivid/vivid-core.c 
b/drivers/media/test-drivers/vivid/vivid-core.c
index 54df7e0c13fc..48809991f037 100644
--- a/drivers/media/test-drivers/vivid/vivid-core.c
+++ b/drivers/media/test-drivers/vivid/vivid-core.c
@@ -1698,10 +1698,8 @@ static int vivid_create_instance(struct platform_device 
*pdev, int inst)
                                       &has_tuner, &has_modulator,
                                       &ccs_cap, &ccs_out,
                                       in_type_counter, out_type_counter);
-       if (ret) {
-               kfree(dev);
-               return ret;
-       }
+       if (ret)
+               goto free_dev;
 
        vivid_set_capabilities(dev);
 
-- 
2.26.2

Reply via email to