On Mon, Aug 31, 2020 at 11:23:00PM +0300, Dmitry Osipenko wrote: > The driver's probe function code is difficult to read and follow. This > patch splits probe function into several logical parts that are easy to > work with. > > Signed-off-by: Dmitry Osipenko <dig...@gmail.com> > --- > drivers/i2c/busses/i2c-tegra.c | 398 ++++++++++++++++++++------------- > 1 file changed, 240 insertions(+), 158 deletions(-) [...]
I can see why you want to extract clock setup and combine DT-parsing parts, but the rest is not that clear. At least the clock setup split should be a separate patch, as it seems to require massive code motion. For eg. runtime PM setup/disable or interrupt setup, I would actually suggest to drop the parts as they make the code harder to follow (you have a function doing nothing but calling another one). Best Regards, Michał Mirosław
